-
-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a last_reviewed_date
to docs metadata
#19200
Conversation
- At the AGM we formed an ad-hoc documentation working group. - One of our ideas was that we should have a last reviewed date for documentation, so that we can periodically implement a review mechanism (GitHub Actions posts to Slack for a regular documentation outdatedness check?) to track how old docs are and ensure they're still relevant. - This is a first step towards that goal, by adding a `last_review_date` to the metadata of all docs with a date of earlier than Homebrew's inception because everything needs reviewing so that we start from a good base!
e99acfe
to
31d7bcc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a linter that checks that new docs have the last_reviewed_date
attribute?
And preferably one that insists you bump the date whenever the document is modified too. |
@@ -1,3 +1,7 @@ | |||
--- | |||
last_review_date: "1970-01-01" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we hold off adding this review date until we've actually (re-)reviewed these documents?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought this was a good "if it's 1970 then it needs review", and gets the metadata used. (We can make a list of docs that need re-review and put it in an issue.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think ideally we'd go with "if it's blank" or "if it's false" or something: we need to review. The 1970 date is a little confusing and harder to "scan" than those.
Pull Request is not mergeable
Yes, I'll add one!
I'm personally against this because you might want to add some information but not feel qualified enough and/or have time to review the whole thing. It's not "last edited", but "last reviewed for accuracy". |
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?last_review_date
to the metadata of all docs with a date of earlier than Homebrew's inception because everything needs reviewing so that we start from a good base!