Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a last_reviewed_date to docs metadata #19200

Merged
merged 2 commits into from
Feb 3, 2025
Merged

Conversation

issyl0
Copy link
Member

@issyl0 issyl0 commented Feb 3, 2025

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

  • At the AGM we formed an ad-hoc documentation working group.
  • One of our ideas was that we should have a last reviewed date for documentation, so that we can periodically implement a review mechanism (GitHub Actions posts to Slack for a regular documentation outdatedness check?) to track how old docs are and ensure they're still relevant.
  • This is a first step towards that goal, by adding a last_review_date to the metadata of all docs with a date of earlier than Homebrew's inception because everything needs reviewing so that we start from a good base!

@issyl0 issyl0 requested a review from EricFromCanada February 3, 2025 11:03
- At the AGM we formed an ad-hoc documentation working group.
- One of our ideas was that we should have a last reviewed date for
  documentation, so that we can periodically implement a review
  mechanism (GitHub Actions posts to Slack for a regular documentation
  outdatedness check?) to track how old docs are and ensure they're
  still relevant.
- This is a first step towards that goal, by adding a `last_review_date`
  to the metadata of all docs with a date of earlier than Homebrew's
  inception because everything needs reviewing so that we start from a
  good base!
@issyl0 issyl0 force-pushed the docs-last-reviewed-date branch from e99acfe to 31d7bcc Compare February 3, 2025 11:56
@issyl0 issyl0 requested a review from krehel February 3, 2025 13:09
@issyl0 issyl0 enabled auto-merge February 3, 2025 13:25
Copy link
Contributor

@colindean colindean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a linter that checks that new docs have the last_reviewed_date attribute?

@issyl0 issyl0 added this pull request to the merge queue Feb 3, 2025
@carlocab
Copy link
Member

carlocab commented Feb 3, 2025

Can we add a linter that checks that new docs have the last_reviewed_date attribute?

And preferably one that insists you bump the date whenever the document is modified too.

@@ -1,3 +1,7 @@
---
last_review_date: "1970-01-01"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we hold off adding this review date until we've actually (re-)reviewed these documents?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought this was a good "if it's 1970 then it needs review", and gets the metadata used. (We can make a list of docs that need re-review and put it in an issue.)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think ideally we'd go with "if it's blank" or "if it's false" or something: we need to review. The 1970 date is a little confusing and harder to "scan" than those.

auto-merge was automatically disabled February 3, 2025 13:38

Pull Request is not mergeable

@issyl0
Copy link
Member Author

issyl0 commented Feb 3, 2025

Can we add a linter that checks that new docs have the last_reviewed_date attribute?

Yes, I'll add one!

And preferably one that insists you bump the date whenever the document is modified too.

I'm personally against this because you might want to add some information but not feel qualified enough and/or have time to review the whole thing. It's not "last edited", but "last reviewed for accuracy".

Merged via the queue into master with commit 2350825 Feb 3, 2025
28 checks passed
@issyl0 issyl0 deleted the docs-last-reviewed-date branch February 3, 2025 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants