-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring ededup as its own namespace dpk_ededup #871
Conversation
Signed-off-by: Maroun Touma <[email protected]>
Signed-off-by: Maroun Touma <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the following links:
- link to the notebook (should point to ededup_python.ipynb, currently pointing to ededup.ipynb)
- link to EdedupTransform (should point to dpk_ededup/transform_base.py, currently pointing to src/ededup_transform_python.py)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, make run-cli-sample
does not work.
python -m dpk_ededup.ray.transform \
--run_locally True --data_local_config "{ 'input_folder' : 'test-data/input', 'output_folder' : 'output'}" \
--ededup_num_hashes 2
Traceback (most recent call last):
File "/usr/lib64/python3.9/runpy.py", line 197, in _run_module_as_main
return _run_code(code, main_globals, None,
File "/usr/lib64/python3.9/runpy.py", line 87, in _run_code
exec(code, run_globals)
File "/home/cma/de/data-prep-kit-pkg/transforms/universal/ededup/dpk_ededup/ray/transform.py", line 18, in <module>
import ray
ModuleNotFoundError: No module named 'ray'
make: *** [Makefile:18: run-cli-sample] Error 1
Can you please activate the virtual environment prior to launching the app?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch. Thanks @cmadam . Done.
Signed-off-by: SHAHROKH DAIJAVAD <[email protected]>
Signed-off-by: SHAHROKH DAIJAVAD <[email protected]>
Signed-off-by: Maroun Touma <[email protected]>
Signed-off-by: matouma <[email protected]>
Moved to main repo for debugging kip |
Why are these changes needed?
First pass at restructuring the transform built as its own module (e.g. dpk_ededup) with a ray submodule (dpk_ededup.ray ).
Removed python and ray folders and refactor Dockerfile.python and Dockerfile.ray
remove pyproject.toml and Makefiles
move python code under dpk_ededup
move ray code under dpk_ededup/ray
change import statement to include module name
replace recursive Makefile and use targets from .make.cicd.targets
adapt kfp_ray/Makefile and other make target
Related issue number (if any).
#774