Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring ededup as its own namespace dpk_ededup #871

Closed
wants to merge 7 commits into from

Conversation

touma-I
Copy link
Collaborator

@touma-I touma-I commented Dec 12, 2024

Why are these changes needed?

First pass at restructuring the transform built as its own module (e.g. dpk_ededup) with a ray submodule (dpk_ededup.ray ).

Removed python and ray folders and refactor Dockerfile.python and Dockerfile.ray
remove pyproject.toml and Makefiles
move python code under dpk_ededup
move ray code under dpk_ededup/ray
change import statement to include module name
replace recursive Makefile and use targets from .make.cicd.targets
adapt kfp_ray/Makefile and other make target

Related issue number (if any).

#774

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the following links:

  • link to the notebook (should point to ededup_python.ipynb, currently pointing to ededup.ipynb)
  • link to EdedupTransform (should point to dpk_ededup/transform_base.py, currently pointing to src/ededup_transform_python.py)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, make run-cli-sample does not work.

python -m dpk_ededup.ray.transform \
                --run_locally True --data_local_config "{ 'input_folder' : 'test-data/input', 'output_folder' : 'output'}"  \
                --ededup_num_hashes 2
Traceback (most recent call last):
  File "/usr/lib64/python3.9/runpy.py", line 197, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/usr/lib64/python3.9/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "/home/cma/de/data-prep-kit-pkg/transforms/universal/ededup/dpk_ededup/ray/transform.py", line 18, in <module>
    import ray
ModuleNotFoundError: No module named 'ray'
make: *** [Makefile:18: run-cli-sample] Error 1

Can you please activate the virtual environment prior to launching the app?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch. Thanks @cmadam . Done.

shahrokhDaijavad and others added 3 commits December 12, 2024 10:20
Signed-off-by: SHAHROKH DAIJAVAD <[email protected]>
Signed-off-by: SHAHROKH DAIJAVAD <[email protected]>
Signed-off-by: Maroun Touma <[email protected]>
@touma-I touma-I changed the title Rfactoring ededup as its own namespace dpk_ededup Refactoring ededup as its own namespace dpk_ededup Dec 13, 2024
@touma-I touma-I requested a review from revit13 December 13, 2024 16:47
Signed-off-by: matouma <[email protected]>
@touma-I touma-I requested a review from cmadam December 14, 2024 09:12
@touma-I touma-I closed this Dec 14, 2024
@touma-I
Copy link
Collaborator Author

touma-I commented Dec 14, 2024

Moved to main repo for debugging kip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants