-
-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix compliance level support for old code #4068
Conversation
Signed-off-by: André Silva <[email protected]>
Signed-off-by: André Silva <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In regards of #4072, I've run the CtGenerationTest
with your changes too, and it takes around 8-10s more time than with the master branch (on my machine).
It would be probably better to keep the static keyword set but remove the version specific ones and add checks for them in the isKeyword
method directly.
Hi @SirYwell You're absolutely right. Thank you and sorry for the regression. I've updated the PR, it should be fixed now. |
Signed-off-by: André Silva <[email protected]>
Nice fix, very helpful to analyze old Java code, which is definitely in our scope. Will merge once CI is green. Thanks @andre15silva |
Green @monperrus |
This PR fixes #4067
Added a test case similar to the problem encountered with the example from
astor
.