Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support VK_KHR_zero_initialize_workgroup_memory #2450

Merged
merged 1 commit into from
Feb 21, 2025
Merged

Support VK_KHR_zero_initialize_workgroup_memory #2450

merged 1 commit into from
Feb 21, 2025

Conversation

dboyan
Copy link
Contributor

@dboyan dboyan commented Feb 18, 2025

As SPIRV-Cross now supports the feature, we can enable VK_KHR_zero_initialize_workgroup_memory here.

Vulkan CTS compute cases before enabling extension:

  Passed:        81/45160 (0.2%)
  Failed:        0/45160 (0.0%)
  Not supported: 45079/45160 (99.8%)

Vulkan CTS compute cases after enabling extension:

  Passed:        712/45160 (1.6%)
  Failed:        0/45160 (0.0%)
  Not supported: 44448/45160 (98.4%)

@dboyan dboyan mentioned this pull request Feb 18, 2025
Open
billhollings
billhollings approved these changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@billhollings billhollings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@billhollings billhollings merged commit 2048427 into KhronosGroup:main Feb 21, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billhollings billhollings billhollings approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dboyan @billhollings