Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow uint8 in NCCL ALLtoALL #376

Merged
merged 1 commit into from
Feb 26, 2025
Merged

Conversation

srivatsankrishnan
Copy link
Contributor

@srivatsankrishnan srivatsankrishnan commented Feb 26, 2025

Summary

Allow the datatype field to be uint8 along with float

Test Plan

CI
Dry-run

(venv) $ cloudai dry-run --system-config ../cloudaix/conf/common/system/xxxx.toml --tests-dir conf/common/test --test-scenario conf/common/test_scenario/nccl_test.toml 
[INFO] System Name: xxxx
[INFO] Scheduler: slurm
[INFO] Test Scenario Name: nccl-test
[INFO] Checking if test templates are installed.
[INFO] Test Scenario: nccl-test

Section Name: Tests.1
  Test Name: nccl_test_all_gather
  Description: all_gather
  No dependencies
[INFO] Initializing Runner [DRY-RUN] mode
[INFO] Creating SlurmRunner
[INFO] Starting test scenario execution.
[INFO] Starting test: Tests.1
[INFO] Running test: Tests.1
[INFO] Submitted slurm job: 0
[INFO] Job completed: Tests.1
[INFO] All test scenario results stored at: results/nccl-test_xxxxxx

Additional Notes

@srivatsankrishnan srivatsankrishnan marked this pull request as ready for review February 26, 2025 02:29
@TaekyungHeo TaekyungHeo added the enhancement New feature or request label Feb 26, 2025
@srivatsankrishnan srivatsankrishnan merged commit c3b12c6 into NVIDIA:main Feb 26, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants