Remove activesupport dependency

[srabuini]

What do you think about adding a simple helper and removing more than 11.000 lines of code?

[NullVoxPopuli]

that sounds great!!!!

[NullVoxPopuli]

can you add tests for the present method for things like '', [], {}, 'not empty', [0], 0, etc?

[srabuini]

I've added almost the same blank/non_blank cases that activesupport tests.

Have a look, please, and let me know.

Thanks!

[NullVoxPopuli]

for both of these tests, can you wrap the actual it blocks in a loop with the array of blank/non-blank data?

something like:

context 'when data is not present' do
  command = 'hi'
  identifier = { 'hi': 'there' }
  expected = {
    command: command,
    identifier: identifier.to_json
  }.to_json

  blank_data.each do |blank_datum|
    it "does not set :data if the value would be #{blank_datum.inspect}" do
      # in the data is present test, the expected will need to move in to here, but that's fine.
      # msg = 
      # expect = 
    end
  end
end

this way of organizing the specs allows for super easy at-a-glance debugging in case one of the cases of the loop fails (the test name tells which thing is specifically being tested)

[NullVoxPopuli]

looking good! just one more change, I think!

[NullVoxPopuli]

should inspect be used here as well?

[srabuini]

Yes. It produces almost the same output, just a vs "a" but should improve readability, I guess.

[NullVoxPopuli]

looks good! thanks! I'll release a new version shortly

[NullVoxPopuli]

@srabuini 2.0.1 released. :-)
Apparently I accidentally released 3. oops. that's been yanked.