Allows disconnected to pass code and reason #37
Conversation
|
|
|
Hi @zedtux ! thanks for the PR! can you add information about this to the README as well? thanks! |
|
Done sir! |
|
Any news please? |
| @@ -33,7 +33,7 @@ This example is compatible with [this version of a small Rails app with Action C | |||
|
|
|||
|
|
|||
| The available hooks to tie in to are: | |||
| - `disconnected {}` | |||
| - `disconnected { |code, reason| }` | |||
There was a problem hiding this comment.
it's been a while for me, but where would someone find out what possible codes and reasons could be passed here?
There was a problem hiding this comment.
I have no idea! The last one I had was reason being AuthError, I don't remember the code.
I guess you can find it from the ActionCable protocol specification, but Is that important for this PR?
There was a problem hiding this comment.
nah, thanks! It's just been ages since I've worked with Rails' things
|
it seems CI isn't set up on this repo 😅 would you be willing to PR a GH action workflow that sets that up? |
|
I'm not sure I can create a PR with that and get it running on your repo, is there any kind of permissions for that? |
|
We'll find out! 🎉 |
No description provided.