Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] account_move_tier_validation: Migration to 18.0 #1830

Open
wants to merge 57 commits into
base: 18.0
Choose a base branch
from

Conversation

kevinkhao
Copy link

@kevinkhao kevinkhao commented Nov 2, 2024

depends on OCA/server-ux#966
EDIT: above PR superseded by OCA/server-ux#992

pegonzalezspesol and others added 30 commits November 2, 2024 14:56
Currently translated at 100.0% (13 of 13 strings)

Translation: account-invoicing-13.0/account-invoicing-13.0-account_move_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-13-0/account-invoicing-13-0-account_move_tier_validation/zh_CN/
Currently translated at 100.0% (22 of 22 strings)

Translation: account-invoicing-14.0/account-invoicing-14.0-account_move_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-14-0/account-invoicing-14-0-account_move_tier_validation/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-invoicing-14.0/account-invoicing-14.0-account_move_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-14-0/account-invoicing-14-0-account_move_tier_validation/
* 'Validation In Progress' so as to allow an easy location of the
   invoices for which a validation has been triggered,
   but it is not yet completed.
* 'Validation Not Started' to locate bills that either require
   no validation, or the request for validation has not yet been initiated.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-invoicing-14.0/account-invoicing-14.0-account_move_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-14-0/account-invoicing-14-0-account_move_tier_validation/
Currently translated at 100.0% (27 of 27 strings)

Translation: account-invoicing-14.0/account-invoicing-14.0-account_move_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-14-0/account-invoicing-14-0-account_move_tier_validation/sv/
pfteyy and others added 6 commits November 11, 2024 08:32
@kevinkhao kevinkhao force-pushed the 18.0-mig-account_move_tier_validation branch 4 times, most recently from d3a8636 to abfa1b4 Compare November 11, 2024 06:55
@kevinkhao
Copy link
Author

@xaviedoanhduy done

Copy link

@xaviedoanhduy xaviedoanhduy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@bosd bosd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, some small improvements.

@kevinkhao kevinkhao force-pushed the 18.0-mig-account_move_tier_validation branch 2 times, most recently from 6009106 to 40dc33f Compare November 12, 2024 06:27
@kevinkhao kevinkhao force-pushed the 18.0-mig-account_move_tier_validation branch from 40dc33f to 62b36c7 Compare November 12, 2024 06:35
@kevinkhao
Copy link
Author

@bosd thx for feedback, done

@bosd
Copy link

bosd commented Nov 12, 2024

Wdyt about promoting module maturity?

Copy link

@CasVissers-360ERP CasVissers-360ERP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review

Copy link

@bosd bosd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional test with:
OCA/server-ux#990

@ivantodorovich
Copy link
Contributor

⚠️ Careful

This PR

Is being superseded by:

Can we put some effort in reviewing the depended module first 🙏🏻

@kevinkhao
Copy link
Author

updated my initial comment for the superseded depending PR

@bosd
Copy link

bosd commented Jan 16, 2025

Thanks, maybe you can close this one now.

@StefanRijnhart
Copy link
Member

Please remove the test dependency now that base_tier_validation is merged.

Copy link

@miikanissi miikanissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just the test dependency to remove and let's get this merged

Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it was proposed almost simultaneously, the migration to 17.0 from #1829 is not included, but there was no substance in there so that's fine. But please include #1880 which was merged recently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.