Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] l10n_es_location_nuts #3619

Merged
merged 16 commits into from
Jun 5, 2024

Conversation

edlopen
Copy link
Member

@edlopen edlopen commented May 31, 2024

Standard migration. I've changed the method to load the states as base_location_nuts, which this module depends on, changed a lot.

@moduon MT-1811

@yajo @EmilioPascual @Shide @fcvalgar @rafaelbn review this PR when you can. Thank you!

To test it you need to run de NUT's import again, then the 4th level Spain nut's states will be loaded.

@edlopen edlopen changed the title 16.0 mig l10n es location nuts [16.0][MIG] l10n_es_location_nuts May 31, 2024
@HaraldPanten
Copy link
Contributor

/ocabot migration l10n_es_location_nuts

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone May 31, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request May 31, 2024
54 tasks
Copy link

@fcvalgar fcvalgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review,

LGTM, thank you @edlopen

image

@EmilioPascual
Copy link
Contributor

@edlopen can you make rebase for run tests again? FACE tests seem to be running ok

@edlopen edlopen force-pushed the 16.0-mig-l10n_es_location_nuts branch from 964ef2d to 1e8d609 Compare June 5, 2024 06:37
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-3619-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 3e3ebd8 into OCA:16.0 Jun 5, 2024
5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 8c1b8c6. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.