Resolve failing alpha package automation #26
Conversation
Update Python version to supported 3.10
WalkthroughThe pull request updates the GitHub Actions workflow configuration file Changes
Suggested Reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/release_workflow.yml (1)
Line range hint
22-31: Consider updating actions in the notify job for consistency.While the main workflow changes look good, consider updating these actions in the notify job for consistency:
- Update
actions/checkout@v2to@v4- Consider updating
fadenb/[email protected]to a newer version if available
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/release_workflow.yml(3 hunks)
🔇 Additional comments (3)
.github/workflows/release_workflow.yml (3)
59-62: Good improvement using a stable release tag.Switching from
@masterto@release/v1for the PyPI publish action provides better stability and security.
71-78: LGTM! Consistent action versions across jobs.The updates maintain consistency with the publish_pypi job and use the latest stable releases of all actions.
42-50: LGTM! Action versions and Python update look good.The updates to the latest versions of actions and Python 3.10 align with the PR objectives and best practices.
Let's verify Python version compatibility with project dependencies:
✅ Verification successful
Python 3.10 update is compatible with project requirements
The project explicitly supports Python 3.10 in setup.py, and no conflicting version requirements were found in the dependencies.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check if setup.py or requirements.txt specify any Python version constraints rg -l "python_requires|Programming Language :: Python" setup.py requirements.txt 2>/dev/null # Check for any potential compatibility issues in dependencies if [ -f "requirements.txt" ]; then echo "Checking requirements.txt for Python 3.10 compatibility..." pip index versions $(cat requirements.txt | grep -v '^#' | cut -d'[' -f1) 2>/dev/null | grep -i "Requires-Python" fiLength of output: 466
Script:
#!/bin/bash # Check setup.py for Python version constraints echo "=== Python version constraints in setup.py ===" rg "python_requires|Programming Language :: Python" setup.py -A 2 -B 2 # Get detailed package requirements echo -e "\n=== Package requirements ===" if [ -f "requirements.txt" ]; then cat requirements.txt fi # Check if any packages specify Python version constraints echo -e "\n=== Checking specific package Python requirements ===" if [ -f "requirements.txt" ]; then while IFS= read -r pkg; do # Skip empty lines and comments [[ -z "$pkg" || "$pkg" =~ ^#.*$ ]] && continue # Extract base package name without version specifiers base_pkg=$(echo "$pkg" | cut -d'[' -f1 | cut -d'>' -f1 | cut -d'<' -f1 | cut -d'=' -f1 | tr -d ' ') echo "Checking $base_pkg..." pip index versions "$base_pkg" 2>/dev/null | grep -i "Requires-Python:" | head -n1 done < requirements.txt fiLength of output: 2588
# Description Update wallpaper plugin to resolve observed issue where default wallpaper is missing from options # Issues - Implements OpenVoiceOS/ovos-PHAL-plugin-wallpaper-manager#24 - Needs OpenVoiceOS/ovos-PHAL-plugin-wallpaper-manager#26 # Other Notes <!-- Note any breaking changes, WIP changes, requests for input, etc. here -->
Update actions versions in release_workflow.yml to latest versions
Update Python version to supported 3.10
Addresses failing action run: https://github.com/OpenVoiceOS/ovos-PHAL-plugin-wallpaper-manager/actions/runs/13010883232/job/36288168593
Updates pypi-publish action per project readme
Summary by CodeRabbit