Skip to content
This repository has been archived by the owner on Feb 12, 2025. It is now read-only.

Replace react-content-loader with css implementation. #484

Merged

Conversation

Hyperkid123
Copy link
Contributor

a detailed description of the issue: danilowoz/react-content-loader#93

jira: https://projects.engineering.redhat.com/browse/SSP-1385

There are no visual changes

Issues

  • safari browser is displaying black stripes in content loaders
  • fix for safari broke chrome on Linux so I removed the library and implemented it using CSS
  • CSS implementation should have much better browser support and is actually customizable

@Hyperkid123 Hyperkid123 added the bug Something isn't working label Mar 26, 2020
@Hyperkid123 Hyperkid123 requested a review from lgalis March 26, 2020 12:49
@lgalis lgalis merged commit d57a9c7 into RedHatInsights:master Mar 26, 2020
@Hyperkid123 Hyperkid123 deleted the patch-content-loader-safari branch March 27, 2020 07:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants