Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group deployable items by priority and deploy in order #27

Closed
Shemnei opened this issue Jul 31, 2021 · 3 comments · Fixed by #82
Closed

Group deployable items by priority and deploy in order #27

Shemnei opened this issue Jul 31, 2021 · 3 comments · Fixed by #82
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@Shemnei
Copy link
Owner

Shemnei commented Jul 31, 2021

Before starting the deployment, group all items by priority. Then deploy in sorted order (highest first). This allows for specilization of single items (when used together with generic directory deploy) and can reduce disk read/writes.

@Shemnei Shemnei added the enhancement New feature or request label Jul 31, 2021
@Shemnei Shemnei added this to the 1.0.0 milestone Jul 31, 2021
@Shemnei Shemnei self-assigned this Jul 31, 2021
@michidk
Copy link
Collaborator

michidk commented Aug 2, 2021

Do we want this in v1 already?

@Shemnei
Copy link
Owner Author

Shemnei commented Aug 2, 2021

I hope that it is not too much work. If it is too much we probably should push it back.
Its a necessary step before we can think about multitasking (e.g. #29).

@Shemnei
Copy link
Owner Author

Shemnei commented Aug 2, 2021

Maybe you are right and we should push it back. We probably also want to sort by merge operation inside the same priority. And have to think about the multitasking model.

@Shemnei Shemnei removed this from the 1.0.0 milestone Aug 2, 2021
@Shemnei Shemnei linked a pull request Nov 20, 2022 that will close this issue
@Shemnei Shemnei added this to the 1.1.0 milestone Nov 23, 2022
bors bot added a commit that referenced this issue Nov 26, 2022
82: More cli commands r=Shemnei a=Shemnei

# Added

- Added new `render` cli command to display resolved template dotfile ([#19](#19))
- Added new `verify` cli command to verify a given profile ([#19](#19))
- Added new `diff` cli command to print the potential diffs of a given profile ([#82](#82))
- Added new `man` cli command to generate man pages for the application ([#82](#82))
- Added new `completions` cli command to generate shell completions for the application ([#82](#82))
- Added `-q/--quite` cli flag to only display errors ([#42](#42))
- Added `--json-output/--yaml-output` cli argument to write the deployment status to files ([#47](#47))
- Added support for symlink creation in profiles ([#54](#54))
- Added path resolving of `~` and environment variables ([#48](#48))
- Added support for the `aliases` attribute in profiles

# Changed

- **BREAKING** The profile cli argument now must be given with the `-p/--profile` specifier ([#82](#82))
- Updated internal workings of the deployment process to make it more flexible ([#82](#82))
- Dotfiles are now sorted by descending priority to maybe reduce disk read/writes ([#27](#27))
- Improved aur package installation; Now includes man page and shell completions ([#82](#82))


Co-authored-by: Jonas Grawe <[email protected]>
bors bot added a commit that referenced this issue Nov 26, 2022
82: More cli commands r=Shemnei a=Shemnei

# Added

- Added new `render` cli command to display resolved template dotfile ([#19](#19))
- Added new `verify` cli command to verify a given profile ([#19](#19))
- Added new `diff` cli command to print the potential diffs of a given profile ([#82](#82))
- Added new `man` cli command to generate man pages for the application ([#82](#82))
- Added new `completions` cli command to generate shell completions for the application ([#82](#82))
- Added `-q/--quite` cli flag to only display errors ([#42](#42))
- Added `--json-output/--yaml-output` cli argument to write the deployment status to files ([#47](#47))
- Added support for symlink creation in profiles ([#54](#54))
- Added path resolving of `~` and environment variables ([#48](#48))
- Added support for the `aliases` attribute in profiles

# Changed

- **BREAKING** The profile cli argument now must be given with the `-p/--profile` specifier ([#82](#82))
- Updated internal workings of the deployment process to make it more flexible ([#82](#82))
- Dotfiles are now sorted by descending priority to maybe reduce disk read/writes ([#27](#27))
- Improved aur package installation; Now includes man page and shell completions ([#82](#82))


Co-authored-by: Jonas Grawe <[email protected]>
bors bot added a commit that referenced this issue Nov 26, 2022
82: More cli commands r=Shemnei a=Shemnei

# Added

- Added new `render` cli command to display resolved template dotfile ([#19](#19))
- Added new `verify` cli command to verify a given profile ([#19](#19))
- Added new `diff` cli command to print the potential diffs of a given profile ([#82](#82))
- Added new `man` cli command to generate man pages for the application ([#82](#82))
- Added new `completions` cli command to generate shell completions for the application ([#82](#82))
- Added `-q/--quite` cli flag to only display errors ([#42](#42))
- Added `--json-output/--yaml-output` cli argument to write the deployment status to files ([#47](#47))
- Added support for symlink creation in profiles ([#54](#54))
- Added path resolving of `~` and environment variables ([#48](#48))
- Added support for the `aliases` attribute in profiles

# Changed

- **BREAKING** The profile cli argument now must be given with the `-p/--profile` specifier ([#82](#82))
- Updated internal workings of the deployment process to make it more flexible ([#82](#82))
- Dotfiles are now sorted by descending priority to maybe reduce disk read/writes ([#27](#27))
- Improved aur package installation; Now includes man page and shell completions ([#82](#82))


Co-authored-by: Jonas Grawe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants