Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup #69

Merged
merged 9 commits into from
Sep 11, 2021
Merged

Cleanup #69

merged 9 commits into from
Sep 11, 2021

Conversation

Shemnei
Copy link
Owner

@Shemnei Shemnei commented Sep 11, 2021 •
edited
Loading

Improvements

#65

New message

Error:
   0: Failed to resolve punktf's source directory (path: /home/a)
   1: No such file or directory (os error 2)

#62

New messages

Error:
   0: Failed to process profile at path `/home/demo/.config/punktf/profiles/demo.json`
   1: Failed to parse profile from json content.
   2: expected value at line 3 column 12
Error:
   0: Failed to process profile at path `/home/demo/.config/punktf/profiles/demo.yaml`
   1: Failed to parse profile from yaml content.
   2: variables: invalid type: sequence, expected struct Variables at line 7 column 3

@Shemnei
Removed current directory as fallback for the source directory
9a2c333 
This caused confusion and probably a bad design decision. Now the only options
to define the source directory are with `-s/--source` or
`PUNKTF_SOURCE`.
@Shemnei
Updated CHANGELOG
1313dad
@Shemnei Shemnei added the enhancement New feature or request label Sep 11, 2021
@Shemnei Shemnei added this to the 1.1.0 milestone Sep 11, 2021
@Shemnei Shemnei self-assigned this Sep 11, 2021
This was linked to issues Sep 11, 2021
Better error message when missing dotfiles/profiles subdirectories #65
Closed
Improve error messages when profile parsing fails #62
Closed
@Shemnei Shemnei requested a review from michidk September 11, 2021 10:59
@Shemnei Shemnei marked this pull request as ready for review September 11, 2021 10:59
michidk
michidk approved these changes Sep 11, 2021
View reviewed changes
Copy link
Collaborator

@michidk michidk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@michidk
Copy link
Collaborator

michidk commented Sep 11, 2021

bors r+

@bors
Copy link
Contributor

bors bot commented Sep 11, 2021

Build succeeded:

@bors bors bot merged commit c8aa7ae into main Sep 11, 2021
@bors bors bot deleted the cleanup branch September 11, 2021 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michidk michidk michidk approved these changes

Assignees

@Shemnei Shemnei

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.1.0
2 participants
@Shemnei @michidk