bugfix: handle absolute and relative paths as expected #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous behavior would take the absolute or relative path and expand the directory structure onto the receiver. This is not what one expects when for instance sending files using the absolute path "portal send /home/zinokader/data/somefile.txt", which previously would actually try to recreate the same directory structure "/home/zinokader..." on the receiver end. Now, we handle absolute paths by sending the last directory or file (and its subfiles/subdirectories), this means "/home/zinokader/folder" will just send and expand "folder" and all of its contents on the receiving end.
ZinoKader
added a commit
that referenced
this pull request
Jan 18, 2023
* feat: use zap everywhere * bugfix: handle absolute and relative paths as expected (#31) * chore: ignore .vscode folder * feat: handle absolute and relative paths as expected Previous behavior would take the absolute or relative path and expand the directory structure onto the receiver. This is not what one expects when for instance sending files using the absolute path "portal send /home/zinokader/data/somefile.txt", which previously would actually try to recreate the same directory structure "/home/zinokader..." on the receiver end. Now, we handle absolute paths by sending the last directory or file (and its subfiles/subdirectories), this means "/home/zinokader/folder" will just send and expand "folder" and all of its contents on the receiving end.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous behavior would take the absolute or relative path and expand the directory structure onto the receiver. This is not what one expects when for instance sending files using the absolute path
portal send /home/zinokader/data/somefile.txt,which previously would actually try to recreate the same directory structure
/home/zinokader...on the receiver end.Now, we handle absolute paths by sending the last directory or file (and its subfiles/subdirectories), this means
/home/zinokader/folderwill just send and expandfolderand all of its contents on the receiving end.fixes #30