Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F/completion #33

Merged
merged 6 commits into from
Feb 15, 2023
Merged

F/completion #33

merged 6 commits into from
Feb 15, 2023

Conversation

mellonnen
Copy link
Member

  • Replaces the old completion command with one generated by cobra-cli
  • Adds password completion for receive command using cobra
    • You will have to add the completion script to your shell according to the instructions in the completion command

@mellonnen mellonnen requested a review from ZinoKader February 14, 2023 23:13
@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2023

Codecov Report

Base: 25.00% // Head: 36.94% // Increases project coverage by +11.94% 🎉

Coverage data is based on head (8e7e398) compared to base (128e5a8).
Patch coverage: 37.17% of modified lines in pull request are covered.

❗ Current head 8e7e398 differs from pull request most recent head 538da94. Consider uploading reports for the commit 538da94 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##           develop      #33       +/-   ##
============================================
+ Coverage    25.00%   36.94%   +11.94%     
============================================
  Files            5        6        +1     
  Lines          172      249       +77     
============================================
+ Hits            43       92       +49     
- Misses         113      130       +17     
- Partials        16       27       +11     
Impacted Files Coverage Δ
internal/conn/conn.go 32.05% <0.00%> (-0.85%) ⬇️
internal/conn/middleware.go 0.00% <0.00%> (ø)
internal/semver/semver.go 41.42% <41.42%> (ø)
portal/portal.go 36.11% <0.00%> (+36.11%) ⬆️
portal/config.go 100.00% <0.00%> (+100.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mellonnen mellonnen merged commit 445cf30 into develop Feb 15, 2023
@ZinoKader ZinoKader deleted the f/completion branch February 19, 2023 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants