Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix]get endpoint from vended credential to be compatible with minio #56256

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

zombee0
Copy link
Contributor

@zombee0 zombee0 commented Feb 25, 2025

Why I'm doing:

What I'm doing:

Fixes #56177

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@zombee0 zombee0 requested a review from a team as a code owner February 25, 2025 07:11
@github-actions github-actions bot added the 3.4 label Feb 25, 2025
Youngwb
Youngwb previously approved these changes Feb 25, 2025
DorianZheng
DorianZheng previously approved these changes Feb 25, 2025
@DorianZheng DorianZheng enabled auto-merge (squash) February 25, 2025 08:05
kevincai
kevincai previously approved these changes Feb 25, 2025
Signed-off-by: zombee0 <[email protected]>
auto-merge was automatically disabled February 25, 2025 10:57

Head branch was pushed to by a user without write access

@zombee0 zombee0 dismissed stale reviews from kevincai, DorianZheng, and Youngwb via 778fc5c February 25, 2025 10:57
Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 3 / 3 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/credential/CloudConfigurationFactory.java 3 3 100.00% []

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Custom S3 Endpoints broken with poco on 3.4.0
4 participants