fix(query-core): fix to show type error when queryKey is a wrong type in invalidateQueries #8691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in invalidateQueries
|
View your CI Pipeline Execution ↗ for commit 475d1e2.
☁️ Nx Cloud last updated this comment at |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8691 +/- ##
===========================================
+ Coverage 46.28% 63.06% +16.78%
===========================================
Files 199 135 -64
Lines 7549 4852 -2697
Branches 1727 1370 -357
===========================================
- Hits 3494 3060 -434
+ Misses 3675 1547 -2128
+ Partials 380 245 -135 |
TkDodo
reviewed
Feb 25, 2025
Comment on lines
+500
to
+518
| it('shows type error when queryKey is a wrong type in invalidateQueries', () => { | ||
| const queryClient = new QueryClient() | ||
|
|
||
| queryClient.invalidateQueries() | ||
|
|
||
| queryClient.invalidateQueries({ | ||
| queryKey: ['1'], | ||
| }) | ||
|
|
||
| queryClient.invalidateQueries({ | ||
| // @ts-expect-error | ||
| queryKey: '1', | ||
| }) | ||
|
|
||
| queryClient.invalidateQueries({ | ||
| // @ts-expect-error | ||
| queryKey: {}, | ||
| }) | ||
| }) |
There was a problem hiding this comment.
I’ve added this test to:
where I’m also re-writing the types for invalidateQueries and other methods.
the test passes there as well, so I’ll close this PR to avoid the conflicts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #8684
Now, the type error is shown when queryKey is a wrong type in invalidateQueries.