Fix scope target, remove redundant code #42
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I faced with issue of wrong camera initial position on next 3d-scene creating after using
enabledPan
and change positions with panning on first/previous scene creating iteration.partialScope
object uses on creating a new instance of the orbit controls. ButpartialScope.target
value not recreates on restingpartialScope
object because it is object(just copy link to Vector3 instance). This can lead to conflicts when using multiple instances at the same time because they will all reference the sametarget
object.maybe fix it #31