Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add M5Stack StampS3 #9950

Merged
merged 13 commits into from
Jan 15, 2025
Merged

Add M5Stack StampS3 #9950

merged 13 commits into from
Jan 15, 2025

Conversation

StellasFun
Copy link

Add code modified from M5Stack Cardputer to allow direct support for the M5StampS3 board
https://shop.m5stack.com/products/m5stamp-esp32s3-module

Code for TFT LCD left intact but commented out, as board is sold with LCD in a variant set
https://shop.m5stack.com/products/cardputer-accessory-kit

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I have a couple questions.

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the copyright update. Please remove the display init code that is commented out.

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you!

@tannewt tannewt merged commit 2e3bdc9 into adafruit:main Jan 15, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants