fix: 🐛 frontend-grayurl 解析不正确导致路由失败 #1550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1550 +/- ##
==========================================
+ Coverage 35.91% 43.52% +7.61%
==========================================
Files 69 76 +7
Lines 11576 12325 +749
==========================================
+ Hits 4157 5364 +1207
+ Misses 7104 6626 -478
- Partials 315 335 +20 |
CH3CHO
requested changes
Nov 28, 2024
| @@ -35,6 +36,10 @@ func parseConfig(json gjson.Result, grayConfig *config.GrayConfig, log wrapper.L | |||
| func onHttpRequestHeaders(ctx wrapper.HttpContext, grayConfig config.GrayConfig, log wrapper.Log) types.Action { | |||
| requestPath, _ := proxywasm.GetHttpRequestHeader(":path") | |||
| requestPath = path.Clean(requestPath) | |||
| parsedURL, err := url.Parse(requestPath) | |||
| if err == nil { | |||
| requestPath = parsedURL.Path | |||
There was a problem hiding this comment.
如果有错误的话，是不是应该记录个日志以便排查？
done
There was a problem hiding this comment.
是不是把解析失败的path也打出来？
好的，已经修改
CH3CHO
requested changes
Nov 28, 2024
| @@ -35,6 +36,10 @@ func parseConfig(json gjson.Result, grayConfig *config.GrayConfig, log wrapper.L | |||
| func onHttpRequestHeaders(ctx wrapper.HttpContext, grayConfig config.GrayConfig, log wrapper.Log) types.Action { | |||
| requestPath, _ := proxywasm.GetHttpRequestHeader(":path") | |||
| requestPath = path.Clean(requestPath) | |||
| parsedURL, err := url.Parse(requestPath) | |||
| if err == nil { | |||
| requestPath = parsedURL.Path | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: 修复 url 解析不正确导致路由失败
refer: #1548