Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update source for images used by ci #557

Merged
merged 11 commits into from
Sep 25, 2023
Merged

update source for images used by ci #557

merged 11 commits into from
Sep 25, 2023

Conversation

rinfx
Copy link
Collaborator

@rinfx rinfx commented Sep 22, 2023

更新ci时镜像源到docker.io

@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2023

Codecov Report

Merging #557 (8ba8b49) into main (26ed9a6) will increase coverage by 0.13%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #557      +/-   ##
==========================================
+ Coverage   37.40%   37.53%   +0.13%     
==========================================
  Files          65       65              
  Lines        9176     9186      +10     
==========================================
+ Hits         3432     3448      +16     
+ Misses       5478     5472       -6     
  Partials      266      266              

see 2 files with indirect coverage changes

@johnlanni
Copy link
Collaborator

BUILDER_REGISTRY ?= higress-registry.cn-hangzhou.cr.aliyuncs.com/plugins/

可以把构建wasm plugin时的基础镜像也换到dockerhub的,可以在这个ci会用到的脚本里设置:
https://github.com/alibaba/higress/blob/main/tools/hack/build-wasm-plugins.sh

@rinfx rinfx requested a review from johnlanni as a code owner September 25, 2023 02:04
@Xunzhuo Xunzhuo merged commit 14e43aa into alibaba:main Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants