Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix reconcile of mcpbridge #559

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Conversation

johnlanni
Copy link
Collaborator

@johnlanni johnlanni commented Sep 25, 2023

Ⅰ. Describe what this PR did

Fix the promblems below:

  1. The wg.Wait may be blocked when the nacos server can not be connected.
  2. The IngressConfig.HasSynced will return true before the processing of mcpbridge resource.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

Codecov Report

Merging #559 (f6f7b98) into main (792b9b0) will increase coverage by 0.17%.
The diff coverage is 6.25%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #559      +/-   ##
==========================================
+ Coverage   37.40%   37.57%   +0.17%     
==========================================
  Files          65       65              
  Lines        9176     9186      +10     
==========================================
+ Hits         3432     3452      +20     
+ Misses       5478     5468      -10     
  Partials      266      266              
Files Changed Coverage Δ
pkg/ingress/config/kingress_config.go 17.31% <0.00%> (ø)
pkg/ingress/config/ingress_config.go 14.12% <6.66%> (-0.13%) ⬇️

... and 1 file with indirect coverage changes

@johnlanni johnlanni merged commit 945787f into alibaba:main Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants