fix gateway name #672
Merged
fix gateway name #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnlanni
requested review from
SpecialYang,
Charlie17Li and
Xunzhuo
as code owners
|
cc @SpecialYang |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #672 +/- ##
==========================================
- Coverage 35.63% 35.58% -0.06%
==========================================
Files 73 73
Lines 10447 10440 -7
==========================================
- Hits 3723 3715 -8
Misses 6438 6438
- Partials 286 287 +1
|
SpecialYang
requested changes
Dec 11, 2023
SpecialYang
reviewed
Dec 11, 2023
| @@ -319,7 +315,7 @@ func (m *KIngressConfig) convertVirtualService(configs []common.WrapperConfig) [ | |||
| common.CreateConvertedName(m.clusterId, cleanHost), | |||
| common.CreateConvertedName(constants.IstioIngressGatewayName, cleanHost)} | |||
| if host != "*" { | |||
| gateways = append(gateways, m.globalGatewayName) | |||
| gateways = append(gateways, m.namespace+"/"+common.CreateConvertedName(m.clusterId, "*")) | |||
There was a problem hiding this comment.
这样更内聚一些，代码可读性好一些，成员变量没有太大必要
There was a problem hiding this comment.
那这样会一直重复计算吧？毕竟是hash计算
There was a problem hiding this comment.
嗯 是的，不过我觉得这里的性能影响也很小，相比下还是可读性重要些
SpecialYang
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
fix #667
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews