refactor: unify image customization methods #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #687 +/- ##
=======================================
Coverage 35.60% 35.60%
=======================================
Files 73 73
Lines 10447 10447
=======================================
Hits 3720 3720
Misses 6440 6440
Partials 287 287 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
#676
Ⅲ. Why don't you add test cases (unit test/integration test)?
i made wasm-plugin test to check if the PR works. It showed no errors.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews
i followed the settings in
values.yaml, the default image for controller is "higress" in customization.I mention this because the other two containers keep their name and image consistent. pilot's default image is "pilot". gateway's image is "gateway". The naming methods of images may be a little bit worth concerning.