Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: shorthand l repeated #702

Merged
merged 1 commit into from
Dec 18, 2023
Merged

bug: shorthand l repeated #702

merged 1 commit into from
Dec 18, 2023

Conversation

sjcsjc123
Copy link
Collaborator

Ⅰ. Describe what this PR did

修复shorthand冲突问题

Ⅱ. Does this pull request fix one issue?

fixes: #701

Ⅲ. Why don't you add test cases (unit test/integration test)?

已在本地测试过dashboard的子命令均能正常打开

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: sjcsjc123 <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #702 (40ee192) into main (5fbfbe0) will not change coverage.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #702   +/-   ##
=======================================
  Coverage   35.17%   35.17%           
=======================================
  Files          74       74           
  Lines       10571    10571           
=======================================
  Hits         3718     3718           
  Misses       6567     6567           
  Partials      286      286           
Files Coverage Δ
pkg/cmd/hgctl/dashboard.go 0.00% <0.00%> (ø)

@2456868764
Copy link
Collaborator

LGTM

@johnlanni johnlanni merged commit f9a015e into alibaba:main Dec 18, 2023
@sjcsjc123 sjcsjc123 deleted the hgctl-bugfix branch January 14, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants