Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-37383][flink-examples]Correct throttling logic on ThrottledIterator #26203

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rafaelzimmermann
Copy link

@rafaelzimmermann rafaelzimmermann commented Feb 24, 2025

What is the purpose of the change

The throttle function was updating its last batch check time before the sleep operation, causing it to underestimate the elapsed time and allow approximately double the intended throughput rate.

Brief change log

Moving the timestamp update to after the sleep ensures the elapsed time calculation properly accounts for the full duration between batches, maintaining the configured rate limit.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

The throttle function was updating its last batch check time before
the sleep operation, causing it to underestimate the elapsed time
and allow approximately double the intended throughput rate.

Moving the timestamp update to after the sleep ensures the elapsed
time calculation properly accounts for the full duration between
batches, maintaining the configured rate limit.
@flinkbot
Copy link
Collaborator

flinkbot commented Feb 24, 2025

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@rafaelzimmermann rafaelzimmermann changed the title Correct throttling logic on ThrottledIterator [FLINK-37383]Correct throttling logic on ThrottledIterator Feb 25, 2025
@rafaelzimmermann rafaelzimmermann changed the title [FLINK-37383]Correct throttling logic on ThrottledIterator [FLINK-37383][flink-examples]Correct throttling logic on ThrottledIterator Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants