KAFKA-18658: add import control for examples module #18812
Conversation
github-actions
bot
added
triage
|
@chia7712 PTAL |
There was a problem hiding this comment.
@gongxuanzhang thanks for this patch. maybe we can just add "used" public packages for now? that can streamline this PR. WDYT
| <allow pkg="org.apache.kafka.common.serialization" /> | ||
| <allow pkg="org.apache.kafka.common.network" /> | ||
| <allow pkg="org.apache.kafka.common.annotation" /> | ||
| <allow pkg="org.apache.kafka.common.utils" /> |
There was a problem hiding this comment.
Now that these apis are open, there is no guarantee that future examples modules will not call them. I think we should add exposed apis to the "allow list".it just means it's allowed.
@chia7712
There was a problem hiding this comment.
org.apache.kafka.common.utils is not public package, and example module should use public APIs only. Otherwise, users may get encouraged by the example to use "internal" APIs
There was a problem hiding this comment.
You are right! I'm sorry for my carelessness. I changed the code,removed all markup unsupported apis . PTAL
There was a problem hiding this comment.
@gongxuanzhang maybe we can add the packages used by current examples? that can streamline this PR
| <allow pkg="org.apache.kafka.streams.errors" /> | ||
| <allow pkg="org.apache.kafka.streams.query" /> | ||
| <allow pkg="org.apache.kafka.streams" /> | ||
| <allow pkg="org.apache.kafka.server" /> |
| <allow pkg="org.apache.kafka.server" /> | ||
| <allow pkg="org.apache.kafka.server.log.remote.storage" /> | ||
| <allow pkg="org.apache.kafka.connect.tools" /> | ||
| <allow pkg="org.apache.kafka.connect.util" /> |
New update were made in accordance with this suggestion. |
|
@chia7712 PTAL |
…ssume-baseline-3.3-for-server * apache-github/trunk: KAFKA-18366 Remove KafkaConfig.interBrokerProtocolVersion (apache#18820) KAFKA-18658 add import control for examples module (apache#18812) MINOR: Java version and TLS documentation improvements (apache#18822) KAFKA-18743 Remove leader.imbalance.per.broker.percentage as it is not supported by Kraft (apache#18821) KAFKA-18225 ClientQuotaCallback#updateClusterMetadata is unsupported by kraft (apache#18196) KAFKA-18441: Remove flaky tag on KafkaAdminClientTest#testAdminClientApisAuthenticationFailure (apache#18847) MINOR: fix KStream#to incorrect javadoc (apache#18838) KAFKA-18763: changed the assertion statement for acknowledgements to include only successful acks (apache#18846) MINOR: Accept specifying consumer group assignors by their short names (apache#18832)
Reviewers: Chia-Ping Tsai <[email protected]>
Reviewers: Chia-Ping Tsai <[email protected]>
fix https://issues.apache.org/jira/browse/KAFKA-18658