MINOR: Move the ELR default version to 4.1 #18954
Conversation
github-actions
bot
added
triage
| @@ -130,7 +130,7 @@ public enum MetadataVersion { | |||
| // Please move this comment when updating the LATEST_PRODUCTION constant. | |||
| // | |||
|
|
|||
| // Not used by anything yet. | |||
| // The default version to enable ELR (KIP-966). | |||
| IBP_4_1_IV0(26, "4.1", "IV0", false); | |||
There was a problem hiding this comment.
The ELR related comments for IBP_4_0_IV1 are a bit unclear - can we clarify them?
There was a problem hiding this comment.
Mentioned 4.0IV1 adds the support for ELR and ELR is only for preview
There was a problem hiding this comment.
I think the comment should be something like "enables ELR by default for new clusters"
dajac
changed the title
| @@ -25,7 +25,7 @@ public enum EligibleLeaderReplicasVersion implements FeatureVersion { | |||
| ELRV_0(0, MetadataVersion.MINIMUM_KRAFT_VERSION, Collections.emptyMap()), | |||
|
|
|||
| // Version 1 enables the ELR (KIP-966). | |||
| ELRV_1(1, MetadataVersion.IBP_4_0_IV1, Collections.emptyMap()); | |||
| ELRV_1(1, MetadataVersion.IBP_4_1_IV0, Collections.emptyMap()); | |||
There was a problem hiding this comment.
I don't think that this will work since it will disable ELR completely for 4.0-IV1.
In any case, we need a test of ELR working with 4.0-IV1.
| @@ -25,7 +25,7 @@ public enum EligibleLeaderReplicasVersion implements FeatureVersion { | |||
| ELRV_0(0, MetadataVersion.MINIMUM_KRAFT_VERSION, Collections.emptyMap()), | |||
|
|
|||
| // Version 1 enables the ELR (KIP-966). | |||
| ELRV_1(1, MetadataVersion.IBP_4_0_IV1, Collections.emptyMap()); | |||
| ELRV_1(1, MetadataVersion.IBP_4_1_IV0, Collections.emptyMap()); | |||
There was a problem hiding this comment.
Do we need to define the dependency on IBP_4_0_IV1?
dajac
added
the
Blocker
|
@CalvinConfluent please add a test case to FormatterTest of someone turning on ELR for formatting when MV = 4.0-IV1. Also add a test case that fails with ELR = 1 and MV = 3.9-IV0 (or other earlier MV) |
This test (Java 23) failed but it passes locally. Looking at the history, it became flaky since a few days ago. Hence it is not related to this patch. Filed https://issues.apache.org/jira/browse/KAFKA-18844. |
- ELR is enabled (ELRV_1) by default if the cluster is created with its bootstrap metadata version >= IBP_4_1_IV0. - ELRV_1 can be manually enabled iff the metadata version is >= IBP_4_0_IV1. Reviewers: Ismael Juma <[email protected]>, Colin P. McCabe <[email protected]>, David Jacot <[email protected]>
|
Merged to trunk and to 4.0. |
|
Interesting, the flaky test looks related to #18845, I added a comment to the JIRA ticket too. |
ELR is enabled (ELRV_1) by default if the cluster is created with its bootstrap metadata version >= IBP_4_1_IV0.
ELRV_1 can be manually enabled iff the metadata version is >= IBP_4_0_IV1.