Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prune plexus dependencies #655

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

Prune plexus dependencies #655

wants to merge 9 commits into from

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Feb 16, 2025

No description provided.

@elharo
Copy link
Contributor Author

elharo commented Feb 16, 2025

Failure looks unrelated and flaky: Server not initialized yet, please try again.

@elharo elharo marked this pull request as ready for review February 16, 2025 13:12
@elharo elharo requested a review from cstamas February 16, 2025 13:12
@cstamas
Copy link
Member

cstamas commented Feb 25, 2025

What does this PR buys to us?

@elharo
Copy link
Contributor Author

elharo commented Feb 25, 2025

https://jlbp.dev/JLBP-1

@cstamas
Copy link
Member

cstamas commented Feb 25, 2025

I think you work against JBLP-1 here: this is mvn3 supplier, so most probably some plexus-utils 3.x will be present and plexus-utils 3.x has no idea about plexus-xml (it comes in play with plexus-utils 4.x). In fact, I'd just downgrade plexus-utils here to 3.5.1 maybe?

@elharo
Copy link
Contributor Author

elharo commented Feb 25, 2025

If something else depends on plexus-utils, it should declare the dependency on plexus-utils. We wouldn't add it if it weren't already here, so we should take it out. Unless there's some weird dependency between plexus-xml and plexus-utils? But if so, then a test is missing because this PR is passing.

@cstamas
Copy link
Member

cstamas commented Feb 25, 2025

This subproject uses plexus-utils, to be precise Xpp3Dom out of it.

  • plexus-utils 3.x contains it
  • plexus-utils 4.x has it removed into plexus-xml
  • plexus-xml 3.x is to be used with Maven 3, while plexus-xml 4.x is to be used with Maven 4 (as it in fact redirects to maven-xml from Maven 4)

Hence, I'd just downgrade the plexus-utils here to 3.x and done.

@elharo
Copy link
Contributor Author

elharo commented Feb 25, 2025

Bleah. Another reason one shouldn't move classes between artifacts. Let me think about this.

@elharo elharo marked this pull request as draft February 25, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants