-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prune plexus dependencies #655
base: master
Are you sure you want to change the base?
Conversation
Failure looks unrelated and flaky: Server not initialized yet, please try again. |
What does this PR buys to us? |
I think you work against JBLP-1 here: this is mvn3 supplier, so most probably some plexus-utils 3.x will be present and plexus-utils 3.x has no idea about plexus-xml (it comes in play with plexus-utils 4.x). In fact, I'd just downgrade plexus-utils here to 3.5.1 maybe? |
If something else depends on plexus-utils, it should declare the dependency on plexus-utils. We wouldn't add it if it weren't already here, so we should take it out. Unless there's some weird dependency between plexus-xml and plexus-utils? But if so, then a test is missing because this PR is passing. |
This subproject uses plexus-utils, to be precise Xpp3Dom out of it.
Hence, I'd just downgrade the plexus-utils here to 3.x and done. |
Bleah. Another reason one shouldn't move classes between artifacts. Let me think about this. |
No description provided.