.gjs conversion #440
Merged
.gjs conversion #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windvis
force-pushed
the
chore/gjs-support
branch
from
9263de4 to
a3db7b9
Compare
|
The linting faillure is because of node 14.. We should bump it to 18 for the dev / CI setup and fix issues for node 14 when we run into them (until the next major, which should be released in the near future). Edit: Resolved by #441 |
|
It seems there is an issue with accidental leading and trailing whitespace due to the conversion. I'm trying to figure out what the best way to deal with this is. Edit: I went with the |
We were using this but didn't list this as a dependency yet. It only worked until now because an other addon brings it in.
This version includes a new convenience import which is nice when we use it in .gjs files.
This adds new import paths for all public (non-deprecated) components and modifiers. This makes it easier to use from .gjs components.
We also inlined the `au-props` modifier since we don't use it in other component and we considered it a private modifier.
This also allows us to remove the (private) legend and content components since we can now define them in the parent component file and make them truly private.
This has the benefit that the private child components can now be inlined so they are really private.
This also allows us to inline the `AuNavigationNarrator` component.
This also allows us to inline the private body and footer components.
Windvis
force-pushed
the
chore/gjs-support
branch
from
a3db7b9 to
21f4824
Compare
The named export from `@ember/component` didn't exist until v4.1 so we fall back to the internal import path on older Ember versions.
Windvis
added
the
internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets up ember-template-imports and converts most components to .gjs files.
Github doesn't have syntax highlighing support for .gjs yet since it requires a certain amount of files in (public?) repos. With this change we're helping a bit 😄.
This is an internal change, consumers shouldn't notice anything different and if they do it's most likely a bug.