-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run CI without building runfiles links #2340
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1e8a3e7
to
9006fd1
Compare
I created bazelbuild/bazel#20577 to track the current failures in CI. |
1cc9350
to
d2ea1dd
Compare
939c9de
to
0c93bac
Compare
0c93bac
to
ec02a94
Compare
ec02a94
to
6a1beae
Compare
illicitonion
approved these changes
Dec 5, 2024
UebelAndre
added a commit
that referenced
this pull request
Dec 6, 2024
This reverts commit b27bf62.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 6, 2024
Reverts #2340 It seems like there were cache hits that dodged an important issue ``` bazel coverage //… ``` ``` ================================================================================ FAIL: //test/unit/crate_name:default/crate-name-test (see /private/var/tmp/_bazel_user/76282c66b0dfe3c5cb9a230bdc913a52/execroot/_main/bazel-out/darwin_arm64-fastbuild/testlogs/test/unit/crate_name/default/crate-name-test/test.log) INFO: From Testing //test/unit/crate_name:default/crate-name-test: ==================== Test output for //test/unit/crate_name:default/crate-name-test: running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s /private/var/tmp/_bazel_user/76282c66b0dfe3c5cb9a230bdc913a52/sandbox/darwin-sandbox/3262/execroot/_main/bazel-out/darwin_arm64-opt-exec-ST-d57f47055a04/bin/external/bazel_tools~remote_coverage_tools_extension~remote_coverage_tools/Main: Cannot locate runfiles directory. (Set $JAVA_RUNFILES to inhibit searching.) ``` This flag still cannot be flipped without breaking coverage it seems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.