Ignore symlinks in workspace discovery #3142
Merged
+27
−80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are edge-cases around bazel output symlinks which are fiddly to cover, and I wouldn't expect people to have symlinks between crates within their local workspace. If they do, they can use the explicit `members` property of the Cargo.toml workspace to explicitly include it.
UebelAndre
approved these changes
Dec 29, 2024
illicitonion
force-pushed
the
workspace-discovery-ignore-symlinks
branch
2 times, most recently
from
bd604e4 to
2f732f3
Compare
illicitonion
force-pushed
the
workspace-discovery-ignore-symlinks
branch
from
2f732f3 to
0c6720c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are edge-cases around bazel output symlinks which are fiddly to cover, and I wouldn't expect people to have symlinks between crates within their local workspace. If they do, they can use the explicit
membersproperty of the Cargo.toml workspace to explicitly include it.