Updated crate_universe bzlmod to support skipping splicing #3148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UebelAndre
force-pushed
the
examples_crate_universe
branch
15 times, most recently
from
f25503b to
ff54164
Compare
illicitonion
approved these changes
Jan 2, 2025
UebelAndre
force-pushed
the
examples_crate_universe
branch
from
ff54164 to
94f9b31
Compare
UebelAndre
force-pushed
the
examples_crate_universe
branch
from
94f9b31 to
7b279b9
Compare
This was referenced Jan 6, 2025
Merged
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
hauserx
added a commit
to hauserx/rules_rust
that referenced
this pull request
Jan 20, 2025
The bazel-lsp uses `rust_host_tools` to perform some actions:
by using:
rust_host_tools = use_extension("@rules_rust//rust:extensions.bzl", "rust_host_tools")
use_repo(rust_host_tools, "rust_host_tools")
See: https://github.com/cameron-martin/bazel-lsp/blob/19b799e528c884be6efeb108ed1840a4edff1330/MODULE.bazel#L14
It started failing after
bazelbuild#3148 because rules_rust's
MODULE.bazel registers toolchain with the same name:
rust_host_tools.host_tools(
name = "rust_host_tools",
)
See: https://github.com/bazelbuild/rules_rust/blob/aae84e97c73eae2e6654e1a7e1b751d0c1f2ac9e/MODULE.bazel#L70
hauserx
added a commit
to hauserx/rules_rust
that referenced
this pull request
Jan 20, 2025
The bazel-lsp uses `rust_host_tools` to perform some actions:
by using:
rust_host_tools = use_extension("@rules_rust//rust:extensions.bzl", "rust_host_tools")
use_repo(rust_host_tools, "rust_host_tools")
See: https://github.com/cameron-martin/bazel-lsp/blob/19b799e528c884be6efeb108ed1840a4edff1330/MODULE.bazel#L14
It started failing after
bazelbuild#3148 because rules_rust's
MODULE.bazel registers toolchain with the same name:
rust_host_tools.host_tools(
name = "rust_host_tools",
)
See: https://github.com/bazelbuild/rules_rust/blob/aae84e97c73eae2e6654e1a7e1b751d0c1f2ac9e/MODULE.bazel#L70
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 20, 2025
The bazel-lsp uses `rust_host_tools` to perform some actions by using:
```starlark
rust_host_tools = use_extension("@rules_rust//rust:extensions.bzl", "rust_host_tools")
use_repo(rust_host_tools, "rust_host_tools")
```
See:
https://github.com/cameron-martin/bazel-lsp/blob/19b799e528c884be6efeb108ed1840a4edff1330/MODULE.bazel#L14
It started failing when using rules_rust from HEAD after
#3148 because rules_rust's
MODULE.bazel registers toolchain with the same name:
```starlark
rust_host_tools.host_tools(
name = "rust_host_tools",
)
```
See:
https://github.com/bazelbuild/rules_rust/blob/aae84e97c73eae2e6654e1a7e1b751d0c1f2ac9e/MODULE.bazel#L70
This was referenced Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional Changes:
rust_host_tools_nightlymodule for exposing a nightly toolchainexamples/crate_universeto use bzlmod