Use display_name for "username" instead of first_name, last_name (#1640) #1638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbbeeston
approved these changes
Feb 20, 2025
daveoconnor
force-pushed
the
doc/1640-changes-to-user-profile
branch
from
092764b to
b993d55
Compare
daveoconnor
force-pushed
the
doc/1640-changes-to-user-profile
branch
from
b993d55 to
fc6e1d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This covers just the first part, refactoring first/last name to a user name value in the user profile and related uses.
The second part of that ticket I moved into a new ticket so I could get this out earlier, get it tested, and any issues could be surfaced asap.