-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix test suite regression in heuristic mapper #559
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #559 +/- ##
=======================================
- Coverage 90.4% 90.4% -0.1%
=======================================
Files 87 87
Lines 10052 10052
Branches 1722 1722
=======================================
- Hits 9093 9092 -1
- Misses 959 960 +1
*This pull request uses carry forward flags. Click here to find out more. |
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
86cf52c
to
b9621fb
Compare
This was really getting frustrating. |
Signed-off-by: burgholzer <[email protected]>
Alright, after some more trial and error it turns out that the error can also be fixed by adding a random suffix to the data logger path, which seems to avoid the concurrency problems. |
Description
Due to some unknown reason, the test suite suddenly started to fail on linux systems for one particular heuristic mapper test.
The underlying issue seems to have been some concurrency issue in combination with the logging functionality in the heuristic mapper.
The fix for now was to add a random suffix to the data logger path for all respective tests.
Checklist: