Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix test suite regression in heuristic mapper #559

Merged
merged 4 commits into from
Nov 16, 2024

Conversation

burgholzer
Copy link
Member

@burgholzer burgholzer commented Nov 16, 2024

Description

Due to some unknown reason, the test suite suddenly started to fail on linux systems for one particular heuristic mapper test.
The underlying issue seems to have been some concurrency issue in combination with the logging functionality in the heuristic mapper.
The fix for now was to add a random suffix to the data logger path for all respective tests.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@burgholzer burgholzer self-assigned this Nov 16, 2024
@burgholzer burgholzer added c++ Anything related to C++ code fix Anything related to bugfixes labels Nov 16, 2024
Copy link

codecov bot commented Nov 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.4%. Comparing base (dd85dd0) to head (1ca32b8).
Report is 148 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #559     +/-   ##
=======================================
- Coverage   90.4%   90.4%   -0.1%     
=======================================
  Files         87      87             
  Lines      10052   10052             
  Branches    1722    1722             
=======================================
- Hits        9093    9092      -1     
- Misses       959     960      +1     
Flag Coverage Δ *Carryforward flag
cpp 90.1% <ø> (-0.1%) ⬇️
python 95.9% <ø> (ø) Carriedforward from b9621fb

*This pull request uses carry forward flags. Click here to find out more.

see 1 file with indirect coverage changes

@burgholzer burgholzer changed the title 🐛 Fix test suite regrssion in heuristic mapper 🐛 Fix test suite regression in heuristic mapper Nov 16, 2024
@burgholzer burgholzer force-pushed the experiment-test-regression branch from 86cf52c to b9621fb Compare November 16, 2024 18:53
@burgholzer
Copy link
Member Author

This was really getting frustrating.
And it was not reproducible on macOS at all.
Due to lack of time, this PR simply drops the one problematic test.
The underlying cause is related to concurrency and how the tests are being run.
However, I it has proven to be quite hard to really find out what is going on.
Assuming CI passes, this should be good enough for now.

@burgholzer burgholzer marked this pull request as ready for review November 16, 2024 18:56
Signed-off-by: burgholzer <[email protected]>
@burgholzer
Copy link
Member Author

Alright, after some more trial and error it turns out that the error can also be fixed by adding a random suffix to the data logger path, which seems to avoid the concurrency problems.
All tests are green again now ✅

@burgholzer burgholzer merged commit d3632f4 into main Nov 16, 2024
22 checks passed
@burgholzer burgholzer deleted the experiment-test-regression branch November 16, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Anything related to C++ code fix Anything related to bugfixes
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant