This repository has been archived by the owner on Sep 27, 2023. It is now read-only.
feat: implement paths for Pipeline
#53
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedeci
commented
Apr 27, 2023
fedeci
commented
Apr 27, 2023
fedeci
commented
Apr 27, 2023
|
oops, i made conflicts! |
|
Fixing them! |
fedeci
force-pushed
the
fedeci/paths-pipeline
branch
from
f15b70a to
2b5732c
Compare
fedeci
commented
Apr 27, 2023
crates/cli/src/git.rs
Outdated
Comment on lines
12
to
32
| pub async fn git_changed_files() -> Result<Vec<String>> { | ||
| let output = Command::new("git") | ||
| .args(["status", "--ignored=no", "--short"]) | ||
| .output() | ||
| .await?; | ||
|
|
||
| if !output.status.success() { | ||
| return Err(anyhow::anyhow!( | ||
| "Failed to get git changed files: {}", | ||
| String::from_utf8_lossy(&output.stderr) | ||
| )); | ||
| }; | ||
|
|
||
| let changed_files = String::from_utf8(output.stdout)? | ||
| .lines() | ||
| .map(|row| row.trim().split(' ').last().unwrap().to_string()) | ||
| .collect(); | ||
|
|
||
| Ok(changed_files) | ||
| } | ||
|
|
There was a problem hiding this comment.
@grant0417 is this CLI run on the backend too? If the answer is affirmative this fn won't work as it tries to detect uncommited changes. It should work correctly in local environment however, I am testing it later.
There was a problem hiding this comment.
Yeah, this run on the backend as well. We might need to pass more info do you can diff between the from and to branch
fedeci
force-pushed
the
fedeci/paths-pipeline
branch
from
c2159c5 to
990bafb
Compare
fedeci
commented
Apr 28, 2023
Comment on lines
+515
to
+516
| std::env::var("CICADA_GIT_BASE"), | ||
| std::env::var("CICADA_GIT_HEAD"), |
There was a problem hiding this comment.
These two new variables should address the problem. The CICADA_GIT_BASE should contain the hash of the latest commit on which cicada was run (for the same branch/pr), while CICADA_GIT_HEAD should be the hash of the commit that triggered the run.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.