Replace AuthConfig with UserSettings in SignUp #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikosdouvlis
changed the title
nikosdouvlis
force-pushed
the
usersettings_signup
branch
from
6a60d15 to
9e009de
Compare
nikosdouvlis
force-pushed
the
usersettings_signup
branch
from
7627641 to
65d98e0
Compare
SokratisVidros
approved these changes
Feb 11, 2022
npetridis
reviewed
Feb 11, 2022
npetridis
reviewed
Feb 11, 2022
|
|
||
| // TODO: SignUp should have a field similar to SignIn's supportedFirstFactors | ||
| // listing the available strategies for this signUp | ||
| const emailLinkStrategyEnabled = firstFactors.includes(emailLinkStrategy); | ||
| const emailLinkStrategyEnabled = | ||
| attributes.email_address.first_factors.includes('email_link'); |
There was a problem hiding this comment.
❓ Does it make sense to also check if attributes.email_address.used_for_first_factor is true
Suggested change
| attributes.email_address.first_factors.includes('email_link'); | |
| attributes.email_address.used_for_first_factor && attributes.email_address.first_factors.includes('email_link'); |
There was a problem hiding this comment.
It should be enough since we only care about the email_link strategy, but @gkats might be able to confirm this
npetridis
reviewed
Feb 11, 2022
| const key = snakeToCamel(name) as keyof Fields; | ||
| acc[key] = desc.required ? 'required' : 'on'; | ||
| return acc; | ||
| }, {} as Fields); |
There was a problem hiding this comment.
I guess this will be part of the refactoring that we will do later on, right?
npetridis
approved these changes
Feb 11, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Packages affected
@clerk/clerk-js@clerk/clerk-react@clerk/nextjs@clerk/types@clerk/clerk-expo@clerk/backend-core@clerk/clerk-sdk-node@clerk/edgebuild/tooling/choreDescription
npm testruns as expected.npm run buildruns as expected.Replace authConfig with userSettings in SignUp