This repository has been archived by the owner on Mar 6, 2020. It is now read-only.
cmd/vendor: ignore invalid XML after <meta> tag #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Port two changes from the upstream basis for the "vendor fetch" remote import path parser: - Go change 14482 cmd/go: use RawToken to parse remote package metadata - Go change 18051 cmd/go: ignore XML errors after Go <meta> tags The first allows "vendor fetch" to accept a server response that matches the "go help importpath" documentation literally, providing solely a "meta" start tag as the entire document. More broadly, it accepts XML documents with improperly nested or even missing elements. The latter allows "vendor fetch" to accept responses that contain invalid XML encountered after having read at least one "meta" start tag successfully, here the invalidity being due to violations other than element nesting.
|
LGTM. and the verification failed on go 1.4.3 only |
|
@davecheney, do you have any feedback on or concerns with this proposal? |
|
Sorry I let this drop. I changed jobs a few months ago and have had zero On Fri, Sep 23, 2016 at 12:49 AM, Steven E. Harris <[email protected]
|
|
Thanks. I've fixed the integration test failure. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #642, port two changes from the upstream basis for the "vendor fetch" remote import path parser:
cmd/go: use RawToken to parse remote package metadata
cmd/go: ignore XML errors after Go tags
The first allows "vendor fetch" to accept a server response that matches the "go help importpath" documentation literally, providing solely a "meta" start tag as the entire document. More broadly, it accepts XML documents with improperly nested or even missing elements.
The latter allows "vendor fetch" to accept responses that contain invalid XML encountered after having read at least one "meta" start tag successfully, here the invalidity being due to violations other than element nesting.