Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding Umask key to Quadlet. (2nd attempt) #25369

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

geraveoyomama
Copy link

Committer: Gerben Damave [email protected]

Does this PR introduce a user-facing change?

Adds the Umask= key for .container is added to the quadlet generator.

attempt no. 2

Closes #25278

Copy link
Contributor

openshift-ci bot commented Feb 19, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: geraveoyomama
Once this PR has been reviewed and has the lgtm label, please assign ygalblum for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, code wise LGTM but please fix your commit message,
remove Committer: Gerben Damave <[email protected]> and then make sure you have an empty line before adding Fixes #25278.
You can edit the commit message with git commit --amend and then just force push the commit again.

Fixes containers#25278

Signed-off-by: Gerben Damave <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Umask=xxxx option to replace PodmanArgs=--umask=xxxx
2 participants