-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed error wrapping in urlopen #818
Merged
engelmi
merged 1 commit into
containers:main
from
engelmi:remove-error-wrapping-in-urlopen
Feb 14, 2025
Merged
Removed error wrapping in urlopen #818
engelmi
merged 1 commit into
containers:main
from
engelmi:remove-error-wrapping-in-urlopen
Feb 14, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🧙 Sourcery has finished reviewing your pull request! Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @engelmi - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a comment explaining why the try/except block was removed from
urlopen
. - Instead of using a list, check if
e.code in (HTTP_RANGE_NOT_SATISFIABLE, HTTP_NOT_FOUND)
.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
By wrapping the raised error from urlopen() in an IOError, the caller can not accurately handle that error anymore as its missing the http response code for http errors, for example. Instead, we do not handle any error at all in the HTTPClient for urlopen and let the error bubble up. This way the caller such as the download_file() can properly handle errors such as skipping retries for 404. Signed-off-by: Michael Engel <[email protected]>
b0bfddc
to
d6f2703
Compare
ericcurtin
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By wrapping the raised error from urlopen() in an IOError, the caller can not accurately handle that error anymore as its missing the http response code for http errors, for example. Instead, we do not handle any error at all in the HTTPClient for urlopen and let the error bubble up. This way the caller such as the download_file() can properly handle errors such as skipping retries for 404.