Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed error wrapping in urlopen #818

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

engelmi
Copy link
Member

@engelmi engelmi commented Feb 14, 2025

By wrapping the raised error from urlopen() in an IOError, the caller can not accurately handle that error anymore as its missing the http response code for http errors, for example. Instead, we do not handle any error at all in the HTTPClient for urlopen and let the error bubble up. This way the caller such as the download_file() can properly handle errors such as skipping retries for 404.

Copy link
Contributor

sourcery-ai bot commented Feb 14, 2025

🧙 Sourcery has finished reviewing your pull request!


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @engelmi - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider adding a comment explaining why the try/except block was removed from urlopen.
  • Instead of using a list, check if e.code in (HTTP_RANGE_NOT_SATISFIABLE, HTTP_NOT_FOUND).
Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

By wrapping the raised error from urlopen() in an IOError, the
caller can not accurately handle that error anymore as its missing
the http response code for http errors, for example. Instead, we do
not handle any error at all in the HTTPClient for urlopen and let
the error bubble up. This way the caller such as the download_file()
can properly handle errors such as skipping retries for 404.

Signed-off-by: Michael Engel <[email protected]>
@engelmi engelmi force-pushed the remove-error-wrapping-in-urlopen branch from b0bfddc to d6f2703 Compare February 14, 2025 14:42
@engelmi engelmi merged commit b1dd195 into containers:main Feb 14, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants