Hard-code the device-mapper graph driver to disabled #2283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtrmac
commented
Apr 5, 2024
| @@ -67,7 +67,6 @@ BuildRequires: go-rpm-macros | |||
| %endif | |||
| BuildRequires: gpgme-devel | |||
| BuildRequires: libassuan-devel | |||
| BuildRequires: pkgconfig(devmapper) | |||
There was a problem hiding this comment.
Thanks for thinking of the CI VMs. We do install device-mapper-devel in them, but the images are used across many repos. W/o trying or checking every single one of them, I can't think of an easy way to confirm 🤔 I think I'm more comfortable leaving it there, and up to some future CI VM package-pruning effort. Though please let me know if you object for any reason.
This follows similar changes to Podman in containers/podman@4073541 and Buildah in containers/buildah#4832 Signed-off-by: Miloslav Trmač <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows similar changes to Podman in
containers/podman@4073541 and Buildah in
containers/buildah#4832
Compare earlier #2161 .
(I didn’t actually test any of the updated installation instructions.)
Cc: @giuseppe