UNTESTED DO NOT MERGE: Update for golang-fips API changes #2305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Ephemeral COPR build failed. @containers/packit-build please check. |
|
From a quick analysis, the For reference, a (private) conversation motivating FIPS variant: https://bugzilla.redhat.com/show_bug.cgi?id=1740920 . |
|
sorry about the delay. my github notifications were messed up. I'll look into this today. |
This passes libtrust tests on macOS, need to also test this with the OpenSSl backend. Signed-off-by: Miloslav Trmač <[email protected]>
|
Follow containers/libtrust#8 for current progress on these build failures. |
|
This was fixed in golang-fips, culminating in containers/libtrust#8 . |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to see what a fix for the Packit-reported failures (as in #2297 (comment) ) would look like.
@lsm5 does this build on all distributions we care about for the
mainbranch of our products?This passes libtrust tests on macOS, I need to also test this with the OpenSSl backend.