Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: pin ddtrace<3.0.0 #8897

Merged
merged 1 commit into from
Feb 21, 2025
Merged

chore: pin ddtrace<3.0.0 #8897

merged 1 commit into from
Feb 21, 2025

Conversation

anakin87
Copy link
Member

@anakin87 anakin87 commented Feb 21, 2025 •
edited
Loading

Related Issues

Proposed Changes:

  • pin ddtrace<3.0.0

How did you test it?

CI

Notes for the reviewer

As explained in #8896, at some point we should make Haystack compatible with ddtrace>=3.0.0

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added unit tests and updated the docstrings
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@anakin87 anakin87 added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Feb 21, 2025
@anakin87 anakin87 marked this pull request as ready for review February 21, 2025 07:49
@anakin87 anakin87 requested a review from a team as a code owner February 21, 2025 07:49
@anakin87 anakin87 requested review from davidsbatista and removed request for a team February 21, 2025 07:49
@anakin87 anakin87 mentioned this pull request Feb 21, 2025
Merged
@coveralls
Copy link
Collaborator

coveralls commented Feb 21, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 13452374238

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.142%
Totals Coverage Status
Change from base Build 13440531900: 0.0%
Covered Lines: 9466
Relevant Lines: 10386
💛 - Coveralls

@anakin87 anakin87 enabled auto-merge (squash) February 21, 2025 07:59
@anakin87 anakin87 merged commit fcca710 into main Feb 21, 2025
31 of 32 checks passed
@anakin87 anakin87 deleted the pin-ddtrace branch February 21, 2025 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpangrazzi mpangrazzi mpangrazzi approved these changes

@davidsbatista davidsbatista Awaiting requested review from davidsbatista davidsbatista is a code owner automatically assigned from deepset-ai/open-source-engineering

Assignees
No one assigned
Labels
ignore-for-release-notes PRs with this flag won't be included in the release notes. topic:build/distribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anakin87 @coveralls @mpangrazzi