Github action for generating typescript models automatically from crds #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
from crds Signed-off-by: Josh Pinkney <[email protected]>
Signed-off-by: Josh Pinkney <[email protected]>
JPinkney
requested review from
amisevsk,
davidfestal and
sleshchenko
as code owners
|
cc @benoitf since you were interested in this as well but I'm unable to add you as a reviewer |
benoitf
reviewed
Mar 23, 2021
Signed-off-by: Josh Pinkney <[email protected]>
Signed-off-by: Josh Pinkney <[email protected]>
|
@sleshchenko so let's try ? |
sleshchenko
approved these changes
Mar 25, 2021
|
/approve |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: JPinkney, sleshchenko The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Merged. First job run failed due unclear reason https://github.com/devfile/api/runs/2191535613?check_suite_focus=true, but the rerun by Florent helped and now types are available https://www.npmjs.com/package/@devfile/api. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR introduces a github action for automatically generating typescript models from crds. It contains two things:
This approach makes it possible to generate types for any other language that is supported by kubernetes-client/gen. The only difference would be the release process.
@elsony Is it possible for someone from the devfile api team to create an organization on npm and add the npm token to this repo so that this github action can reference it?
What issues does this PR fix or reference?
#353
Is your PR tested? Consider putting some instruction how to test your changes
The github action was tested on my fork: https://github.com/JPinkney/api/actions
Docs PR