Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devfile Ecosystem update #14

Merged
merged 4 commits into from
May 3, 2022
Merged

Devfile Ecosystem update #14

merged 4 commits into from
May 3, 2022

Conversation

kim-tsao
Copy link
Contributor

@kim-tsao kim-tsao commented Apr 8, 2022

Signed-off-by: Kim Tsao [email protected]

What does this PR do / why we need it:

Introduces a new Devfile Ecosystem section to explain the big picture

Which issue(s) this PR fixes:

Fixes #?

devfile/api#819

PR acceptance criteria:

  • Unit Tests
  • E2E Tests
  • Documentation

How to test changes / Special notes to the reviewer:

Tested locally with with yarn dev and yarn start

@kim-tsao kim-tsao requested review from elsony and schultzp2020 April 8, 2022 20:19
@openshift-ci openshift-ci bot requested a review from maysunfaisal April 8, 2022 20:19
@kim-tsao kim-tsao requested a review from jc-berger April 14, 2022 15:22
@kim-tsao kim-tsao requested a review from HarshCasper April 26, 2022 17:57
kim-tsao added 2 commits May 2, 2022 16:39
Signed-off-by: Kim Tsao <[email protected]>
Signed-off-by: Kim Tsao <[email protected]>
jc-berger
jc-berger previously approved these changes May 3, 2022
Copy link

@jc-berger jc-berger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Signed-off-by: Kim Tsao <[email protected]>
@elsony
Copy link

elsony commented May 3, 2022

/approve

@elsony
Copy link

elsony commented May 3, 2022

/lgtm

@HarshCasper
Copy link
Member

/lgtm

@kim-tsao kim-tsao requested review from johnmcollier and removed request for HarshCasper May 3, 2022 14:38
@openshift-ci
Copy link

openshift-ci bot commented May 3, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elsony, jc-berger, kim-tsao, schultzp2020

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label May 3, 2022
@kim-tsao kim-tsao merged commit 36d22be into devfile:main May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants