Skip to content
This repository has been archived by the owner on Jan 24, 2025. It is now read-only.

chore(docz-core): copy .eslintignore from project #1201

Merged
merged 1 commit into from
Oct 25, 2019

Conversation

Kerumen
Copy link
Contributor

@Kerumen Kerumen commented Oct 25, 2019

Description

Gatsby has an Eslint plugin by default. It is run when we start the project. However, the cwd is at that time the .docz folder. Hence, if we add an .eslintignore in our project, it is not picked up. This add a build step to copy the file into the .docz folder if it exists.

Side note, I didn't understand what is the purpose of the function above, writeEslintRc, as it has an effect only in the Docz repository..

@Kerumen Kerumen added the docz-core Issues related to package docz-core label Oct 25, 2019
@Kerumen Kerumen self-assigned this Oct 25, 2019
@rakannimer
Copy link
Contributor

Looks good !

I think writeEslintRc is because of the previous docz development setup that required the cli to behave differently when in the docz codebase.

@rakannimer rakannimer merged commit 78d2bca into master Oct 25, 2019
@rakannimer rakannimer deleted the copy-eslintignore branch October 25, 2019 10:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
docz-core Issues related to package docz-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants