This repository has been archived by the owner on Jan 24, 2025. It is now read-only.
Add jsxFrag pragma #1269
Merged
Add jsxFrag pragma #1269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a component is specifying a jsx pragma and is using `<></>` Fragment shorthand, they must also specify a fragment pragma. https://babeljs.io/docs/en/next/babel-plugin-transform-react-jsx.html#fragments
|
Thank you @tamagokun for catching this and fixing it ! |
|
Released in 2.0.0-rc.76 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If a component is specifying a jsx pragma and is using
<></>Fragment shorthand, they must also specify a fragment pragma.https://babeljs.io/docs/en/next/babel-plugin-transform-react-jsx.html#fragments
Without this, i'm getting an error when using docz in conjunction with a plugin:
node_modules/gatsby-theme-docz/src/components/Sidebar/index.js: transform-react-jsx: pragma has been set but pragmafrag has not been setReview
Pre-merge checklist
Screenshots