Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix depth texture being incorrectly affected by swap table #13345

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Tilka
Copy link
Member

@Tilka Tilka commented Feb 11, 2025

This fixes issue 13734: "Z-textures are incorrectly affected by swaptable". This was reported by @fadedled, who presumably noticed this while working on Seta GX.

I've not hardware-tested this myself beyond running the repro case using the hardware fifoplayer.

@iwubcode
Copy link
Contributor

If this is true, it would help to add a fifo to the builder to ensure we maintain this? @JMC47

@JMC47
Copy link
Contributor

JMC47 commented Feb 15, 2025

Added the test.

@iwubcode
Copy link
Contributor

@Tilka - is this ready to go or do you plan on hardware testing it first?

@Tilka
Copy link
Member Author

Tilka commented Feb 25, 2025

is this ready to go or do you plan on hardware testing it first?

I don't think I'll get around to doing more detailed hardware tests.

@dolphin-ci
Copy link

dolphin-ci bot commented Feb 25, 2025

FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:

  • zbuff-test on ogl-lin-mesa: diff
  • zbuff-test on mvk-osx-m1: diff
  • zbuff-test on mtl-osx-m1: diff

automated-fifoci-reporter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants