Fake api_versions for old brokers, rename to ApiVersionsRequest, and handle error decoding #2494
+226
−111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpkp
force-pushed
the
dpkp/api-versions
branch
from
64bf2f5 to
9f1fa84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates api_version handling so that versions are normalized against the list in kafka.protocol.broker_api_verisons, which includes copies of api_versions_response data from all brokers 0.10+ and synthetic responses for earlier brokers based on expected api availability. The broker_api_versions data is also used to provide api_versions data to the client when
api_versionis passed as configuration to avoid check_version() api calls.Also renames
ApiVersionRequest=>ApiVersionsRequestand moves fromkafka.protocol.admin=>kafka.protocol.api_versions.