Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: Backend #3063

Merged
merged 40 commits into from
May 15, 2024
Merged

API: Backend #3063

merged 40 commits into from
May 15, 2024

Conversation

guydc
Copy link
Contributor

@guydc guydc commented Mar 30, 2024

What this PR does / why we need it:

This is a preliminary API proposal for discussion purposes only. The new Backend API allows users to reference UDS, FQDN and IP backends with an alternative to the K8s Service resources. See design doc for more details.

Which issue(s) this PR fixes:
Relates to #2997, #36

Signed-off-by: Guy Daich <[email protected]>
@guydc guydc added the area/api API-related issues label Mar 30, 2024
@guydc guydc requested a review from a team as a code owner March 30, 2024 00:51
Copy link

codecov bot commented Mar 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.14%. Comparing base (c4b0216) to head (5b69c70).
Report is 1 commits behind head on main.

❗ Current head 5b69c70 differs from pull request most recent head 3148915. Consider uploading reports for the commit 3148915 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3063      +/-   ##
==========================================
+ Coverage   66.97%   67.14%   +0.17%     
==========================================
  Files         164      165       +1     
  Lines       23882    23845      -37     
==========================================
+ Hits        15994    16011      +17     
+ Misses       6964     6916      -48     
+ Partials      924      918       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Guy Daich <[email protected]>
@zirain
Copy link
Member

zirain commented Mar 31, 2024

so these's something like ServiceEntry in Istio?

Signed-off-by: Guy Daich <[email protected]>
Copy link
Member

@Xunzhuo Xunzhuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this idea, Is this like istio`s ServiceEntry ?

@guydc
Copy link
Contributor Author

guydc commented Apr 1, 2024

@zirain, @Xunzhuo - There are some differences from ServiceEntry.

  • ServiceEntry doesn't support Unix Domain Sockets
  • You can route from VirtualService to external services by just specifying their address. You don't need a ServiceEntry for that, but a ServiceEntry allows you to configure some setting related to DNS resolution, (m)TLS, etc. In EG, this resource (or Service + FQDN Endpoint) is mandatory for external routing.

@guydc guydc added this to the v1.1.0-rc1 milestone Apr 18, 2024
guydc added 2 commits April 23, 2024 08:54
Signed-off-by: Guy Daich <[email protected]>
Signed-off-by: Guy Daich <[email protected]>
@guydc
Copy link
Contributor Author

guydc commented May 14, 2024

/retest

@guydc
Copy link
Contributor Author

guydc commented May 15, 2024

/retest

Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks ! looking forward to using this API

@arkodg arkodg requested review from a team, zirain, Xunzhuo, zhaohuabing and shawnh2 May 15, 2024 21:28
Copy link
Member

@zhaohuabing zhaohuabing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@guydc guydc merged commit 16f1b43 into envoyproxy:main May 15, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api API-related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants