-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API: Backend #3063
API: Backend #3063
Conversation
Signed-off-by: Guy Daich <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3063 +/- ##
==========================================
+ Coverage 66.97% 67.14% +0.17%
==========================================
Files 164 165 +1
Lines 23882 23845 -37
==========================================
+ Hits 15994 16011 +17
+ Misses 6964 6916 -48
+ Partials 924 918 -6 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Guy Daich <[email protected]>
so these's something like |
Signed-off-by: Guy Daich <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this idea, Is this like istio`s ServiceEntry ?
@zirain, @Xunzhuo - There are some differences from
|
Signed-off-by: Guy Daich <[email protected]>
Signed-off-by: Guy Daich <[email protected]>
Signed-off-by: Guy Daich <[email protected]>
Signed-off-by: Guy Daich <[email protected]>
Signed-off-by: Guy Daich <[email protected]>
Signed-off-by: Guy Daich <[email protected]>
Signed-off-by: Guy Daich <[email protected]>
Signed-off-by: Guy Daich <[email protected]>
/retest |
Signed-off-by: Guy Daich <[email protected]>
Signed-off-by: Guy Daich <[email protected]>
Signed-off-by: Guy Daich <[email protected]>
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks ! looking forward to using this API
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
What this PR does / why we need it:
This is a preliminary API proposal for discussion purposes only. The new
Backend
API allows users to reference UDS, FQDN and IP backends with an alternative to the K8sService
resources. See design doc for more details.Which issue(s) this PR fixes:
Relates to #2997, #36